IAmChrisAMA
/
pokerogue
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly reset data when logging out to avoid data leakage

pull/73/head
Flashfyre 2024-04-09 18:48:34 -04:00
parent 3e5a0d5c9c
commit 15e3fefd80
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/battle-scene.ts
View File

@ -591,7 +591,10 @@ export default class BattleScene extends SceneBase {
return this.currentBattle.randSeedInt(this, range, min); return this.currentBattle.randSeedInt(this, range, min);
} }
reset(clearScene?: boolean): void { reset(clearScene: boolean = false, clearData: boolean = false): void {
if (clearData)
this.gameData = new GameData(this);
this.gameMode = gameModes[GameModes.CLASSIC]; this.gameMode = gameModes[GameModes.CLASSIC];
this.setSeed(SEED_OVERRIDE || Utils.randomString(24)); this.setSeed(SEED_OVERRIDE || Utils.randomString(24));

2
src/ui/menu-ui-handler.ts
View File

@ -284,7 +284,7 @@ export default class MenuUiHandler extends MessageUiHandler {
if (!res.ok) if (!res.ok)
console.error(`Log out failed (${res.status}: ${res.statusText})`); console.error(`Log out failed (${res.status}: ${res.statusText})`);
Utils.setCookie(Utils.sessionIdKey, ''); Utils.setCookie(Utils.sessionIdKey, '');
updateUserInfo().then(() => this.scene.reset(true)); updateUserInfo().then(() => this.scene.reset(true, true));
}); });
}; };
if (this.scene.currentBattle) { if (this.scene.currentBattle) {