Add color for the IV scanner (#363)

* Add color for the IV scanner

add a new color SUMMARY_GREEN in text.js, add the green color if the iv of the pokemon is better than the iv on the starter of that pokemon

Co-authored-by: EmoUsedHM01 <131687820+emousedhm01@users.noreply.github.com>

* fix battle-message-ui-handler.ts formatting

* fix missing similicon battle-message-ui-handler.ts

* modified so it take a boolean instead of doing lot of else if battle-message-ui-handler.ts

---------

Co-authored-by: EmoUsedHM01 <131687820+emousedhm01@users.noreply.github.com>

src/ui/battle-message-ui-handler.ts

@@ -1,5 +1,5 @@
 import BattleScene, { Button } from "../battle-scene";
-import { addTextObject, TextStyle } from "./text";
+import { addBBCodeTextObject, addTextObject, getTextColor, TextStyle } from "./text";
 import { Mode } from "./ui";
 import * as Utils from "../utils";
 import MessageUiHandler from "./message-ui-handler";
@@ -9,7 +9,7 @@ import { addWindow } from "./ui-theme";
 export default class BattleMessageUiHandler extends MessageUiHandler {
   private levelUpStatsContainer: Phaser.GameObjects.Container;
   private levelUpStatsIncrContent: Phaser.GameObjects.Text;
-  private levelUpStatsValuesContent: Phaser.GameObjects.Text;
+  private levelUpStatsValuesContent: BBCodeText;
   private nameBox: Phaser.GameObjects.NineSlice;
   private nameText: Phaser.GameObjects.Text;
 
@@ -29,7 +29,7 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
     this.textCallbackTimer = null;
 
     const bg = this.scene.add.sprite(0, 0, 'bg', this.scene.windowType);
-		bg.setOrigin(0, 1);
+                bg.setOrigin(0, 1);
     ui.add(bg);
 
     this.bg = bg;
@@ -95,18 +95,19 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
 
     this.levelUpStatsContainer = levelUpStatsContainer;
 
-    const levelUpStatsBg = addWindow(this.scene, (this.scene.game.canvas.width / 6), -100, 128, 100);
+    const levelUpStatsLabelsContent = addTextObject(this.scene, (this.scene.game.canvas.width / 6) - 73, -94, '', TextStyle.WINDOW, { maxLines: 6 });
-    levelUpStatsBg.setOrigin(1, 0);
-    levelUpStatsContainer.add(levelUpStatsBg);
-
-    const levelUpStatsLabelsContent = addTextObject(this.scene, (this.scene.game.canvas.width / 6) - 121, -94, '', TextStyle.WINDOW, { maxLines: 6 });
     let levelUpStatsLabelText = '';
 
     const stats = Utils.getEnumValues(Stat);
     for (let s of stats)
       levelUpStatsLabelText += `${getStatName(s)}\n`;
-
     levelUpStatsLabelsContent.text = levelUpStatsLabelText;
+    levelUpStatsLabelsContent.x -= levelUpStatsLabelsContent.displayWidth;
+
+    const levelUpStatsBg = addWindow(this.scene, (this.scene.game.canvas.width / 6), -100, 80 + levelUpStatsLabelsContent.displayWidth, 100);
+    levelUpStatsBg.setOrigin(1, 0);
+    levelUpStatsContainer.add(levelUpStatsBg);
+
     levelUpStatsContainer.add(levelUpStatsLabelsContent);
 
     const levelUpStatsIncrContent = addTextObject(this.scene, (this.scene.game.canvas.width / 6) - 50, -94, '+\n+\n+\n+\n+\n+', TextStyle.WINDOW, { maxLines: 6 });
@@ -114,7 +115,7 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
 
     this.levelUpStatsIncrContent = levelUpStatsIncrContent;
 
-    const levelUpStatsValuesContent = addTextObject(this.scene, (this.scene.game.canvas.width / 6) - 7, -94, '', TextStyle.WINDOW, { maxLines: 6 });
+    const levelUpStatsValuesContent = addBBCodeTextObject(this.scene, (this.scene.game.canvas.width / 6) - 7, -94, '', TextStyle.WINDOW, { maxLines: 6 , lineSpacing: 5});
     levelUpStatsValuesContent.setOrigin(1, 0);
     levelUpStatsValuesContent.setAlign('right');
     levelUpStatsContainer.add(levelUpStatsValuesContent);
@@ -208,7 +209,7 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
         } else
           shownStats = stats;
         for (let s of stats)
-          levelUpStatsValuesText += `${shownStats.indexOf(s) > -1 ? this.getIvDescriptor(ivs[s]) : '???'}\n`;
+          levelUpStatsValuesText += `${shownStats.indexOf(s) > -1 ? this.getIvDescriptor(ivs[s], s) : '???'}\n`;
         this.levelUpStatsValuesContent.text = levelUpStatsValuesText;
         this.levelUpStatsIncrContent.setVisible(false);
         this.levelUpStatsContainer.setVisible(true);
@@ -221,18 +222,29 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
     });
   }
 
-  getIvDescriptor(value: integer): string {
+  getIvDescriptor(value: integer, typeIv: integer): string {
+    let starterIvs: number[] = this.scene.gameData.dexData[this.scene.getEnemyPokemon().species.speciesId].ivs;
+    let uiTheme = (this.scene as BattleScene).uiTheme; // Assuming uiTheme is accessible
+
+    // Function to wrap text in color based on comparison
+    const coloredText = (text: string, isBetter: boolean) => {
+      const textStyle: TextStyle = isBetter ? TextStyle.SUMMARY_GREEN : TextStyle.SUMMARY;
+      const color = getTextColor(textStyle, false, uiTheme);
+      return `[color=${color}][shadow=${getTextColor(textStyle, true, uiTheme)}]${text}[/shadow][/color]`;
+    };
+
     if (value > 30)
-      return 'Best';
+      return coloredText('Best', value > starterIvs[typeIv]);
     if (value === 30)
-      return 'Fantastic';
+      return coloredText('Fantastic', value > starterIvs[typeIv]);
     if (value > 20)
-      return 'Very Good';
+      return coloredText('Very Good', value > starterIvs[typeIv]);
     if (value > 10)
-      return 'Pretty Good';
+      return coloredText('Pretty Good', value > starterIvs[typeIv]);
-    if (value)
+    if (value > 0)
-      return 'Decent';
+      return coloredText('Decent', value > starterIvs[typeIv]);
-    return 'No Good';
+
+    return coloredText('No Good', value > starterIvs[typeIv]);
   }
 
   showNameText(name: string): void {
@@ -244,4 +256,4 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
   hideNameText(): void {
     this.nameBoxContainer.setVisible(false);
   }
-}
+}

src/ui/text.ts

@@ -19,6 +19,7 @@ export enum TextStyle {
   SUMMARY_PINK,
   SUMMARY_GOLD,
   SUMMARY_GRAY,
+  SUMMARY_GREEN,
   MONEY,
   SETTINGS_LABEL,
   SETTINGS_SELECTED,
@@ -82,6 +83,7 @@ function getTextStyleOptions(style: TextStyle, uiTheme: UiTheme, extraStyleOptio
     case TextStyle.SUMMARY_PINK:
     case TextStyle.SUMMARY_GOLD:
     case TextStyle.SUMMARY_GRAY:
+    case TextStyle.SUMMARY_GREEN:
     case TextStyle.WINDOW:
     case TextStyle.WINDOW_ALT:
     case TextStyle.MESSAGE:
@@ -160,6 +162,8 @@ export function getTextColor(textStyle: TextStyle, shadow?: boolean, uiTheme: Ui
       return !shadow ? '#e8e8a8' : '#a0a060';
     case TextStyle.SUMMARY_GRAY:
       return !shadow ? '#a0a0a0' : '#636363';
+    case TextStyle.SUMMARY_GREEN:
+      return !shadow ? '#78c850' : '#306850';
     case TextStyle.SETTINGS_LABEL:
       return !shadow ? '#f8b050' : '#c07800';
     case TextStyle.SETTINGS_SELECTED: