cdnutter
/
pokerogue
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix double battle iv scanner color (#379) 

* Add color for the IV scanner

add a new color SUMMARY_GREEN in text.js, add the green color if the iv of the pokemon is better than the iv on the starter of that pokemon

Co-authored-by: EmoUsedHM01 <131687820+emousedhm01@users.noreply.github.com>

* fix battle-message-ui-handler.ts formatting

* fix missing similicon battle-message-ui-handler.ts

* modified so it take a boolean instead of doing lot of else if battle-message-ui-handler.ts

* Fix iv scanner only doing color for the right pokemon in double fight

---------

Co-authored-by: EmoUsedHM01 <131687820+emousedhm01@users.noreply.github.com>
pull/384/head
Mistmemo 2024-05-01 16:50:13 +02:00 committed by GitHub
parent fc1a9f0283
commit 56b24c70b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ui/battle-message-ui-handler.ts
View File

@ -210,7 +210,7 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
} else
shownStats = stats;
for (let s of stats)
levelUpStatsValuesText += `${shownStats.indexOf(s) > -1 ? this.getIvDescriptor(ivs[s], s) : '???'}\n`;
levelUpStatsValuesText += `${shownStats.indexOf(s) > -1 ? this.getIvDescriptor(ivs[s], s, pokemonId) : '???'}\n`;
this.levelUpStatsValuesContent.text = levelUpStatsValuesText;
this.levelUpStatsIncrContent.setVisible(false);
this.levelUpStatsContainer.setVisible(true);
@ -223,8 +223,8 @@ export default class BattleMessageUiHandler extends MessageUiHandler {
});
}
getIvDescriptor(value: integer, typeIv: integer): string {
const starterSpecies = this.scene.getEnemyPokemon().species.getRootSpeciesId(true);
getIvDescriptor(value: integer, typeIv: integer, pokemonId: integer): string {
const starterSpecies = this.scene.getPokemonById(pokemonId).species.getRootSpeciesId(true);
const starterIvs: number[] = this.scene.gameData.dexData[starterSpecies].ivs;
const uiTheme = (this.scene as BattleScene).uiTheme; // Assuming uiTheme is accessible