From eac9b4d385a137e24601953ae1dd237ef6cdcd14 Mon Sep 17 00:00:00 2001
From: TeKrop <tekrop@proton.me>
Date: Wed, 1 May 2024 00:11:05 +0200
Subject: [PATCH] fix: reworked daily and weekly rankings translations workflow

---
 src/locales/de/menu.ts         | 2 +-
 src/locales/en/menu.ts         | 2 +-
 src/locales/es/menu.ts         | 2 +-
 src/locales/fr/menu.ts         | 2 +-
 src/locales/it/menu.ts         | 2 +-
 src/ui/daily-run-scoreboard.ts | 5 +++--
 6 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/locales/de/menu.ts b/src/locales/de/menu.ts
index 4876fa343..442cfae21 100644
--- a/src/locales/de/menu.ts
+++ b/src/locales/de/menu.ts
@@ -59,8 +59,8 @@ export const menu: SimpleTranslationEntries = {
     "escapeVerbSwitch": "auswechseln",
     "escapeVerbFlee": "flucht",
     "notDisabled": "{{moveName}} ist\nnicht mehr deaktiviert!",
-    "rankings": "Rankings",
     "dailyRankings": "Daily Rankings",
+    "weeklyRankings": "Weekly Rankings",
     "noRankings": "No Rankings",
     "loading": "Loading…",
     "playersOnline": "Players Online"
diff --git a/src/locales/en/menu.ts b/src/locales/en/menu.ts
index 1d840a3eb..82a09e49d 100644
--- a/src/locales/en/menu.ts
+++ b/src/locales/en/menu.ts
@@ -78,8 +78,8 @@ export const menu: SimpleTranslationEntries = {
     "skipItemQuestion": "Are you sure you want to skip taking an item?",
     "eggHatching": "Oh?",
     "ivScannerUseQuestion": "Use IV Scanner on {{pokemonName}}?",
-    "rankings": "Rankings",
     "dailyRankings": "Daily Rankings",
+    "weeklyRankings": "Weekly Rankings",
     "noRankings": "No Rankings",
     "loading": "Loading…",
     "playersOnline": "Players Online"
diff --git a/src/locales/es/menu.ts b/src/locales/es/menu.ts
index e72710cee..5dccc2e4e 100644
--- a/src/locales/es/menu.ts
+++ b/src/locales/es/menu.ts
@@ -62,8 +62,8 @@ export const menu: SimpleTranslationEntries = {
     "skipItemQuestion": "¿Estás seguro de que no quieres coger un objeto?",
     "eggHatching": "¿Y esto?",
     "ivScannerUseQuestion": "¿Quieres usar el Escáner de IVs en {{pokemonName}}?",
-    "rankings": "Rankings",
     "dailyRankings": "Daily Rankings",
+    "weeklyRankings": "Weekly Rankings",
     "noRankings": "No Rankings",
     "loading": "Loading…",
     "playersOnline": "Players Online"
diff --git a/src/locales/fr/menu.ts b/src/locales/fr/menu.ts
index 037f0f3b5..d5478c67a 100644
--- a/src/locales/fr/menu.ts
+++ b/src/locales/fr/menu.ts
@@ -73,8 +73,8 @@ export const menu: SimpleTranslationEntries = {
   "skipItemQuestion": "Êtes-vous sûr·e de ne pas vouloir prendre d’objet ?",
   "eggHatching": "Oh ?",
   "ivScannerUseQuestion": "Utiliser le Scanner d’IV sur {{pokemonName}} ?",
-  "rankings": "Classement",
   "dailyRankings": "Classement du Jour",
+  "weeklyRankings": "Classement de la Semaine",
   "noRankings": "Pas de Classement",
   "loading": "Chargement…",
   "playersOnline": "Joueurs Connectés"
diff --git a/src/locales/it/menu.ts b/src/locales/it/menu.ts
index b9e288c26..c37a37b51 100644
--- a/src/locales/it/menu.ts
+++ b/src/locales/it/menu.ts
@@ -7,8 +7,8 @@ export const menu: SimpleTranslationEntries = {
     "loadGame": "Carica Partita",
     "dailyRun": "Corsa Giornaliera (Beta)",
     "selectGameMode": "Seleziona una modalità di gioco.",
-    "rankings": "Rankings",
     "dailyRankings": "Daily Rankings",
+    "weeklyRankings": "Weekly Rankings",
     "noRankings": "No Rankings",
     "loading": "Loading…",
     "playersOnline": "Players Online"
diff --git a/src/ui/daily-run-scoreboard.ts b/src/ui/daily-run-scoreboard.ts
index 1379ec6a8..8f7ca0bf1 100644
--- a/src/ui/daily-run-scoreboard.ts
+++ b/src/ui/daily-run-scoreboard.ts
@@ -11,6 +11,7 @@ interface RankingEntry {
   wave: integer
 }
 
+// Don't forget to update translations when adding a new category
 enum ScoreboardCategory {
   DAILY,
   WEEKLY
@@ -40,7 +41,7 @@ export class DailyRunScoreboard extends Phaser.GameObjects.Container {
     const titleWindow = addWindow(this.scene, 0, 0, 114, 18, false, false, null, null, WindowVariant.THIN);
     this.add(titleWindow);
 
-    this.titleLabel = addTextObject(this.scene, titleWindow.displayWidth / 2, titleWindow.displayHeight / 2, i18next.t('menu:dailyRankings'), TextStyle.WINDOW, { fontSize: '64px' });
+    this.titleLabel = addTextObject(this.scene, titleWindow.displayWidth / 2, titleWindow.displayHeight / 2, i18next.t('menu:loading'), TextStyle.WINDOW, { fontSize: '64px' });
     this.titleLabel.setOrigin(0.5, 0.5);
     this.add(this.titleLabel);
 
@@ -156,7 +157,7 @@ export class DailyRunScoreboard extends Phaser.GameObjects.Container {
         .then(jsonResponse => {
           this.page = page;
           this.category = category;
-          this.titleLabel.setText(`${Utils.toReadableString(ScoreboardCategory[category])} ${i18next.t("menu:rankings")}`);
+          this.titleLabel.setText(`${i18next.t(`menu:${ScoreboardCategory[category].toLowerCase()}Rankings`)}`);
           this.prevPageButton.setAlpha(page > 1 ? 1 : 0.5);
           this.nextPageButton.setAlpha(page < this.pageCount ? 1 : 0.5);
           this.pageNumberLabel.setText(page.toString());