Commit Graph
25 Commits
Author SHA1 Message Date
Benjamin Odom ea5e535f9f Fixed Failed Moves Not Using PP (#634)
Fixed an issue where if a move failed, it would not use power points.
2024-05-08 15:51:56 -05:00
Benjamin Odom 4509e08dc6 Renamed the Python Script File (#657)
Accidentally left out the 'c' in 'comments'
2024-05-08 15:50:31 -05:00
Benjamin Odom bb6bb1e6c1 Fixed Crash Moves and Reckless (#609)
* Fixed Crash Moves and Reckless

Added a new MoveFlags flag 'RECKLESS_MOVE' to make crash and recoil moves in line with other move flag boosting attacks.

Modified how flags were defined so they are easier to maintain.

Added the appropriate flag to all mvoes listed as being affected by Reckless. Steel Beam and Mind Blown do not count according to source:
https://bulbapedia.bulbagarden.net/wiki/Reckless_(Ability)

* Update move.ts

* Update abilities.ts
2024-05-07 23:28:35 -05:00
Benjamin Odom ce3d12d58e Added hyperlinks to Moves, Abilities, and Species enums (#586)
* Added hyperlinks to Moves enum

Yes, I'm aware of what this looks like in the file itself, but it enables a nice neat little hyperlink shown below to the bulbapedia page when you hover over a move. I feel like the added convenience is worth making the file harder to read considering nobody is ever going to touch that file anyway. I plan on adding a python script to finish the rest of them, but didn't want to actually sink time into this if we absolutely despise it.

* Added Python Script

Created a python script to add comments with a url to abilities.ts, moves.ts, and species.ts using regex
2024-05-07 23:18:19 -05:00
Benjamin Odom bd839a1ffb FIx Sceptile and Blaziken Learnsets (#606)
These got missed in the transition from looking at Serebii and Bulbapedia for data.
2024-05-07 13:42:07 -05:00
Benjamin Odom f18ff5b6cc Update Learnsets for Gen3 to Indigo Disk (#571)
* Updated Learnset of Gen1 to Indigo Disc

Not many changes here for how much time it takes to comb through, but here it is.

Only notable change is Power-Up Punch got removed this gen so it had to be removed from Hitmonchan's learnset. Are we okay with this change? If so, this is good to go for Gen 1.

* Updated Learnset of Gen2 to Indigo Disc

Notable changes:

Porygon 2 loses Magic Coat with no replacement.

Ho-oh loses Burn Up but gains Overheat.

The rest seems better or neutral.

* Update Learnsets for Gen3 to Indigo Disk

A good chunk of these changes is just reordering the moves to match bulbapedia so that it's easier to see what changed in the future. Otherwise, it's really just replacing moves that don't exist anymore.

Also, Zangoose got a ton of new moves that work with a move relearner, but not by level-up. Weird, but good if you like Zangoose.

* Fix Duplicates
2024-05-06 19:54:02 -05:00
Benjamin Odom 2b4dc9a4f0 Fixes Struggle Softlock (#531)
* Fixes Struggle Softlock

Fixed an issue where moves marked as (N) would prevent you from being able to Struggle.

Also fixes messaging so that a message shows when you are out of PP, Disabled, or trying to use an unimplemented move consistently.

* Update phases.ts
2024-05-06 00:02:52 -04:00
Benjamin Odom e6fd331931 Fix HalfSacrificialAttr
Mind Blown targets all users and was triggering recoil every time it hit. Changed so that it only applies once after all targets take damage by adding a new MoveEffectTrigger, POST_TARGET. This also fixes an issue where dying to recoil stopped the rest of the damage from hitting the remaining targets.

This change also applies fixes for Steel Beam since they are have the same effect but is single target.

Also added missing messages for Damp and Recoil. All messaging is in line with Pokémon Showdown.
2024-05-05 17:46:15 -04:00
Benjamin Odom faf1c0bce6 Small Typo when Learning a TM
Fixes a small typo when learning a tm. The incorrect escape character was being used and no escape character was being used for Spanish.
2024-05-05 10:45:47 -04:00
Benjamin Odom 3ed7649ce5 Remove Debug Code (#480)
Remove code intended only for debugging.
2024-05-05 18:45:54 +10:00
Benjamin Odom dd76cbc7a2 Add Setting to Swap A and B on Gamepad (#474)
* Add Setting to Swap A and B on Gamepad

Added a new setting to swap the A and B button on controller. Defaults to off which retains the current behavior on live.

* Add comments
2024-05-05 01:25:57 -04:00
Benjamin Odom daa6e3b3a8 Prevent Fusion Status Errors +Fix Double Battle Issue (#472)
* Reapply "Prevent Fusing Status Errors (#465)"

This reverts commit 18a1c152c0.

* Update phases.ts
2024-05-04 22:16:59 -05:00
Benjamin Odom 68eca464f7 Prevent Fusing Status Errors (#465) 2024-05-04 20:37:31 -05:00
Benjamin Odom d170aeeab6 Updated Learnset of Gen2 to Indigo Disc (#469)
* Updated Learnset of Gen1 to Indigo Disc

Not many changes here for how much time it takes to comb through, but here it is.

Only notable change is Power-Up Punch got removed this gen so it had to be removed from Hitmonchan's learnset. Are we okay with this change? If so, this is good to go for Gen 1.

* Updated Learnset of Gen2 to Indigo Disc

Notable changes:

Porygon 2 loses Magic Coat with no replacement.

Ho-oh loses Burn Up but gains Overheat.

The rest seems better or neutral.
2024-05-04 20:27:01 -05:00
Benjamin Odom f53c699d04 Updated Learnset of Gen1 to Indigo Disc
Not many changes here for how much time it takes to comb through, but here it is.

Only notable change is Power-Up Punch got removed this gen so it had to be removed from Hitmonchan's learnset. Are we okay with this change? If so, this is good to go for Gen 1.
2024-05-04 13:43:07 -04:00
Benjamin Odom b529eee5ac Add Form Text to Starter UI (#446)
* Add Form Text to Starter UI

Adds text to the starter screen UI which indicates which Form you are currently selecting. This helps with Pokémon who don't have a sprite change for their form because it doesn't affect them until later.

* Make Title Case
2024-05-04 00:02:55 -04:00
Benjamin Odom 5d6181926a Removed Hardcoded Values
Realized there was an enum for the -1 value which should help clear up confusion if someone has to mess with this code later
2024-05-03 23:26:56 -04:00
Benjamin Odom e02b85629f Fix Enemy Counter Moves
The AI couldn't decide who to target with CounterDamageAttr  moves which don't need a target. This change makes an exception. Now functions the same as when the player selects one of these moves.
2024-05-03 21:00:56 -04:00
Benjamin Odom 313fdc0e42 Fix Venom Drench not working on Toxic Status 2024-05-03 16:48:11 -04:00
Benjamin Odom 3b61662bba Fixed Mighty Cleave not being a Slicing Move 2024-05-03 16:18:29 -04:00
Benjamin Odom b84a4b4ee5 Fix Shedinja PPused Share
Fixed having Shedinja share PP usage with the Ninjask it evolved from and vice versa.

The solution was to make a deep copy of each move in the moveset array rather than copying the array itself.
2024-05-03 08:33:33 -04:00
Benjamin Odom fec8771830 Fix Shedinja Luck and Crash
Shedinja wasn't taking the luck value from Ninjask so when it calculated its luck it just took the entire fused Pokemon's luck somehow. This has been fixed so it takes both the first and second part of the fusion's luck values instead.

Also fixes an issue where Shedinja crashed the game if it was the second part of a fusion combo. Now the correct pokemon species gets checked against and the correct pokemon evolution occurs to create Shedinja.
2024-05-02 17:55:45 -04:00
Benjamin Odom 9d8f7ddcf0 Implement Tailwind (#398)
Added a new ArenaTagType for Tailwind. Lasts 4 turns including the turn used.
2024-05-02 14:10:21 -05:00
Benjamin Odom c9152cda3f Fix Mobile PWA not showing in true Fullscreen (#394)
* Fixed Rounding Error For TargetHalfHpDamageAttr

Moves that deal half of a target's HP were not able to deal damage if the target had 1 HP. Used Math.max to ensure 1 is the lowest this value ever evaluates to.

* Fix Mobile PWA not showing in true Fullscreen

adding "fullscreen" to the display attribute wasn't enough, but adding it to the start_url attribute was. This does not appear to affect PC (which is good since it shouldn't).

* Allow any orientation for mobile PWA

remove the orientation restriction since it doesn't prevent fullscreen PWA from displaying properly.
2024-05-02 01:17:32 -04:00
Benjamin Odom ad59c0a7c4 Fixed Rounding Error For TargetHalfHpDamageAttr
Moves that deal half of a target's HP were not able to deal damage if the target had 1 HP. Used Math.max to ensure 1 is the lowest this value ever evaluates to.
2024-05-01 19:14:18 -04:00